refactor(theming): Replace security annotations with respective attributes #46819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
added
3. to review
skjnldsv
approved these changes
Jul 27, 2024
provokateurin
force-pushed
the
refactor/theming/security-attributes
branch
from
9be6257 to
fbe83f5
Compare
…butes Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
refactor/theming/security-attributes
branch
from
fbe83f5 to
79d9f2e
Compare
juliusknorr
approved these changes
Jul 29, 2024
solracsf
reviewed
Jul 29, 2024
| @@ -420,6 +421,9 @@ public function getThemeStylesheet(string $themeId, bool $plain = false, bool $w | |||
| * 200: Manifest returned | |||
| * 404: App not found | |||
| */ | |||
| #[PublicPage] | |||
| #[NoCSRFRequired] | |||
| #[BruteForceProtection('manifest')] | |||
There was a problem hiding this comment.
This is causing PSALM to fail on master.
There was a problem hiding this comment.
Oops, I thought I had fixed all of them. Let me quickly fix this
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #46606
Checklist